Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: refactor to new styles for 0.8 #929

Merged
merged 107 commits into from Aug 19, 2019

Conversation

@AquiGorka
Copy link
Member

commented Jul 18, 2019

image

How to test

Assuming everything is in the ~/projects directory (replace by your own).

First time

Clone this repo + Aragon client’s + aragonUI’s if not done already:

cd ~/projects
git clone git@github.com:aragon/aragon-apps.git
git clone git@github.com:aragon/aragon.git
git clone git@github.com:aragon/aragon-ui.git

Create a link for aragonUI (npm might tell you that it is already done):

cd ~/projects/aragon-ui
npm link

Getting updates

Here we are updating the branches + reinstalling the dependencies + linking aragonUI again.

cd ~/projects/aragon-ui
git checkout newstyle
git pull origin newstyle
npm install

cd ~/projects/aragon
git checkout newstyle
git pull origin newstyle
npm install
npm link @aragon/ui

cd ~/projects/aragon-apps/apps/finance/app
git checkout newstyle/finance
git pull origin newstyle/finance
npm install
npm link @aragon/ui

Running it

We can now start the two servers (the app + Aragon client). In one shell session (or tab in your terminal app):

cd ~/projects/aragon-apps/apps/finance/app
npm start

In another session (we are asking the client to load apps running locally):

cd ~/projects/aragon
env REACT_APP_ASSET_BRIDGE=local yarn start

Open http://localhost:3000/ in your browser.

@AquiGorka AquiGorka requested review from bpierre, 2color and sohkai Jul 18, 2019

@dizzypaty dizzypaty self-requested a review Jul 18, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jul 18, 2019

Coverage Status

Coverage remained the same at 97.914% when pulling 25fac75 on newstyle/finance into a4f873e on newstyle-0.8.

@luisivan luisivan referenced this pull request Jul 22, 2019
1 of 1 task complete

@AquiGorka AquiGorka changed the base branch from master to newstyle-0.8 Aug 16, 2019

`}
>
<DropDown
placeholder="Type"

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 16, 2019

Member

cc @dizzypaty Does it make sense for this to be renamed "Transfer type" or "Transaction type"?

@sohkai

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

@dizzypaty I've lowered the vertical padding of the empty state just a tad: the designs have them at around 160px (20 grid units) but I've taken them down to 120px (15 grid units) because on a 1440x900 display (usually a 13' laptop), the text gets cut off:

Screen Shot 2019-08-18 at 1 02 22 AM

sohkai added some commits Aug 17, 2019

@sohkai sohkai merged commit 2e8e1f3 into newstyle-0.8 Aug 19, 2019

2 of 5 checks passed

Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the newstyle/finance branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.