Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finance: increase gas estimate for deposits #978

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@izqui
Copy link
Member

commented Sep 9, 2019

Fixes aragon/aragon#834

The transaction linked in the issue would have worked with 431,885 gas (if all accounting periods were already transitioned, which I assume that was the case given that the gas estimate was 420k). In any case, the real amount of gas that is actually used is lower, but because of DelegateProxy's FWD_GAS_LIMIT the transaction needs extra gas that is not used. I created an issue on aragonOS to rethink this: aragon/aragonOS#556

There's another factor that we are not taking into account in this estimate and that is if the transaction is the first one in the accounting period, 15k more gas are needed as there is an extra slot that is changed from zero to non-zero

@izqui izqui requested a review from sohkai Sep 9, 2019

@auto-assign auto-assign bot requested a review from bpierre Sep 9, 2019

@coveralls

This comment has been minimized.

Copy link

commented Sep 9, 2019

Coverage Status

Coverage remained the same at 97.914% when pulling 35f17d6 on fix-finance-deposit-estimate into cccb032 on master.

@sohkai
sohkai approved these changes Sep 9, 2019

@sohkai sohkai merged commit 93b2adb into master Sep 9, 2019

6 checks passed

License Compliance All checks passed.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
coverage/coveralls Coverage remained the same at 97.914%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the fix-finance-deposit-estimate branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.