Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments to `apm publish --files` are filtered out by the ignore list #581

Open
sohkai opened this issue Jul 4, 2019 · 0 comments

Comments

2 participants
@sohkai
Copy link
Member

commented Jul 4, 2019

馃悰 Bug Report

Environment

  • aragonCLI 5.6.2 (but think this applies to all future versions too)

To Reproduce

  1. Clone https://github.com/aragonone/approvals/tree/d4430154936f1f87ecf123cd449684c5736267c2
  2. After doing npm install in the root and in the app folder, run npm start in the root
  3. The Aragon client starts, but when you try to go to the Approvals app, it'll say it can't resolve an index.html file

This is because the project has a .gitignore file, that includes build. We manually specify --files app/build during the publish (and run) process, and despite specifying it, the gitignore pattern gets applied and ignores this.

Expected behavior

Files specified through --files would override the ignore list.

Actual Behavior

Files specified through --files are ignored by the .gitignore or .ipfsignore.

Note that we were able to fix this by adding a blank .ipfsignore file (see commit), which is OK, but a bit confusing :).

@sohkai sohkai added the 馃悰 bug label Jul 4, 2019

@0xGabi 0xGabi self-assigned this Jul 6, 2019

@0xGabi 0xGabi added this to To do in Aragon Mesh Team via automation Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.