New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janky network id fix #155

merged 2 commits into from Jul 10, 2018


None yet
3 participants
Copy link

jtremback commented Jul 10, 2018

No description provided.

@sohkai sohkai requested a review from izqui Jul 10, 2018


This comment has been minimized.

Copy link

sohkai commented Jul 10, 2018

@izqui Maybe we can just use a hardcoded network id, e.g. 15?

@@ -54,7 +54,8 @@ exports.task = async function ({ port = 8545, reset = false, showAccounts = 2 })
const server = ganache.server({
mnemonic: MNEMONIC,
db_path: snapshotPath
db_path: snapshotPath,
network_id: Math.floor(Math.random() * 1000)

This comment has been minimized.


izqui Jul 10, 2018


As @sohkai points out, the networkId that is used to generate the snapshot is 15. We should keep using 15 to avoid potential issues.

@izqui izqui merged commit bacfdf9 into aragon:master Jul 10, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
license/cla Contributor License Agreement is signed.

@izqui izqui referenced this pull request Jul 10, 2018


Metamask nonce issue #156


This comment has been minimized.

Copy link

jtremback commented Jul 11, 2018

Sorry guys, shouldn't have made this a PR... I'm not sure this is a good fix.

galactusss added a commit to galactusss/aragon-cli that referenced this pull request Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment