New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin IPFS to v0.4.17 #259

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tommycox
Copy link

tommycox commented Nov 5, 2018

Fixes #257
npm not being able to find IPFS during npm i -g @aragon/cli

Pin IPFS to v0.4.17
Fixes npm not being able to find IPFS during `npm i -g @aragon/cli`
@tommycox

This comment has been minimized.

Copy link

tommycox commented Nov 5, 2018

Something to consider: the tests didn't catch the failing case (for the past couple of days) since the CLI was being installed from source and not npm... Perhaps the tests should utilize npm to ensure the same use cases that the end users are going to experience are covered.

@izqui

This comment has been minimized.

Copy link
Member

izqui commented Nov 5, 2018

Woops sorry I missed the notification and already implemented it in #260 :(

Thanks so much for the contribution! Also saw your PR upstream, as soon as it gets released we will revert the change and pin to the fixed version.

Yeah, there are really no tests beyond the init command right now, it is something we need to work on.

@izqui izqui closed this Nov 5, 2018

@tommycox tommycox deleted the tommycox:feature/pin-ipfs-0.4.17 branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment