New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using fixed 2.2.1 ganache-core version #276

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@macor161
Copy link
Contributor

macor161 commented Nov 16, 2018

Fixes #274

This is a temporary fix until we get to know exactly what in the new ganache-core version is causing the bug.

@0x6431346e

This comment has been minimized.

Copy link
Member

0x6431346e commented Nov 29, 2018

I think we can close this in favor of aragon/aragen#25 which will rebuild the snapshot using 2.3.1, therefore new users will have the correct dependency, and old users can do:
npm i -g @aragon/cli
aragon devchain --reset

thoughts @sohkai ?

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Nov 30, 2018

@0x6431346e Actually we were debating about publishing a hotfix version with this merged, since 2.3.1 may have snapshot issues and we were having a difficult time generating it through the CI.

@0x6431346e

This comment has been minimized.

Copy link
Member

0x6431346e commented Dec 1, 2018

Looks like bingen published 5.2.1 with the pinned version 🎉.
Closing for #280
Thank you @macor161!

@0x6431346e 0x6431346e closed this Dec 1, 2018

@bingen

This comment has been minimized.

Copy link
Contributor

bingen commented Dec 1, 2018

Yes, sorry, @macor161 I forgot you had already submitted that PR. But thanks anyway for your help!!

@bingen

This comment has been minimized.

Copy link
Contributor

bingen commented Dec 1, 2018

Btw, I opened a PR in ganache-core repo, not sure if that's the best way to fix it, but their tests are passing and our cli is working with it:
trufflesuite/ganache-core#239

@macor161

This comment has been minimized.

Copy link
Contributor

macor161 commented Dec 1, 2018

@bingen No problem at all :)

@macor161 macor161 deleted the macor161:ganache-core-fix branch Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment