Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issues and PR templates, edit contributing.md && add codeowners #428

Merged
merged 2 commits into from Apr 9, 2019

Conversation

2 participants
@0xGabi
Copy link
Member

0xGabi commented Apr 8, 2019

closes #400

I included a basic version of CODEOWNER.md to start experiment with while we create a more general approach across repos (as discussed in #412).

@0xGabi 0xGabi added the 📚 docs label Apr 8, 2019

@0xGabi 0xGabi requested a review from 0x6431346e Apr 8, 2019

@0xGabi 0xGabi added this to In progress in Aragon Mesh Team via automation Apr 8, 2019

@0xGabi 0xGabi moved this from In progress to Review in Aragon Mesh Team Apr 8, 2019

@sohkai
Copy link
Member

sohkai left a comment

On the topic of CODEOWNERS, I will be doing a sweep through all of the unarchived repos under the project and adding CODEOWNERS in a week or two :).

- Limit the first line to 72 characters or less
- Reference issues and pull requests liberally after the first line

## JavaScript

All JavaScript must adhere to [JavaScript Standard Style](https://standardjs.com/).

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 9, 2019

Member

I'm not really sure this is true anymore, since the project uses prettier. I'd just say ESLint and prettier are set up to automatically lint and format all code.


### JavaScript
See how a minor change to your commit message style can make you a better programmer.

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 9, 2019

Member

Hehe awesome ❤️ !

@0xGabi 0xGabi merged commit d95804a into aragon:master Apr 9, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

Aragon Mesh Team automation moved this from Review to Done Apr 9, 2019

@0xGabi 0xGabi deleted the 0xGabi:docs/issue-templates branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.