New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up commands #53

Merged
merged 10 commits into from Apr 13, 2018

Conversation

Projects
None yet
1 participant
@onbjerg
Contributor

onbjerg commented Mar 25, 2018

Requires #52

Makes commands beautiful and also sections the logic into different tasks, making it easier to extract and reuse them. Still a bit WIP since I want to extract some of the common tasks into their own files.

See an example of the init command here.

A nice effect of this is that having small tasks and extracting them into their own functions means that the CLI app will become more testable.

onbjerg added some commits Mar 25, 2018

@onbjerg onbjerg added the enhancement label Mar 25, 2018

@onbjerg onbjerg requested a review from izqui Mar 25, 2018

@onbjerg onbjerg referenced this pull request Mar 27, 2018

Closed

Run command #55

onbjerg added some commits Mar 29, 2018

This was referenced Apr 5, 2018

@onbjerg onbjerg merged commit 0cfa806 into master Apr 13, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@onbjerg onbjerg deleted the cleanup-commands branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment