Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more dependencies #759

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@chrishobcroft
Copy link
Contributor

commented Sep 10, 2019

make and g++

馃 Pull Request

The instructions didn't make it clear that you need make and g++ installed in order to be able to biuld.

馃毃 Test instructions

鉁旓笍 PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this
Added more dependencies
make and g++

@chrishobcroft chrishobcroft requested review from 0x6431346e and 0xGabi as code owners Sep 10, 2019

@sohkai

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

I think those might just be generic node dependencies; were you able to get node installed on a linux machine without make and g++ @chrishobcroft?

@chrishobcroft

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

I think those might just be generic node dependencies; were you able to get node installed on a linux machine without make and g++ @chrishobcroft?

No - the npm install -g @aragon/cli command failed twice - firstly because it said it couldn't find make and secondly because it couldn't find g++.

For information, this was on a clean Digital Ocean Ubuntu 18.04.3 LTS image.

@sohkai
sohkai approved these changes Sep 11, 2019

@0xGabi 0xGabi merged commit 7b49ee7 into aragon:master Sep 11, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.