Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #13 and #76 #79

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@luisivan
Copy link
Member

commented Jul 10, 2019

Checks network from signing provider, and then loads the Aragon client in that network.
Fixes #13 and #76

Show resolved Hide resolved src/main.js
Show resolved Hide resolved src/main.js Outdated
const networkConfig = networks[network]
if (!networkConfig) {
if (!networks[network] && network !== 'local') {

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 10, 2019

Member
Suggested change
if (!networks[network] && network !== 'local') {
if (! networkConfig && network !== 'local') {

Although I'm not sure what would happen on local; I don't know if we publish aragon/aragon on aragen (cc @0xGabi)

This comment has been minimized.

Copy link
@0xGabi

0xGabi Jul 10, 2019

Member

No, we didn't publish aragon/aragon on current version. I just open an issue 👍

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

I think solving #13 would require making a change to our navigation handler, so that instead of the URL, we base it on the user's connected ETH network (although I'm not 100% sure if that's what #13 is for).

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Should we also include a way for users to switch off of the ethereum provider's node, or is that something we'd expect them to do from there?

@luisivan

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

I think solving #13 would require making a change to our navigation handler, so that instead of the URL, we base it on the user's connected ETH network (although I'm not 100% sure if that's what #13 is for).

#13 was just to automatically detect the network that the user is connected to via their signing provider, not for dynamically changing if the signing provider's network changes

@luisivan

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2019

Should we also include a way for users to switch off of the ethereum provider's node, or is that something we'd expect them to do from there?

I'd expect them to do all of their node management from the signing provider, yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.