Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to be compatible with new publish script #71

Merged
merged 3 commits into from Aug 1, 2019

Conversation

@0xGabi
Copy link
Member

commented Jul 31, 2019

Now the publish script not include all folder by default. It will only include the minimum necessary files (manifest.json, artifact.json and code.sol).

Then we need to include the dist folder to include the App front-end.

TODO:

  • Same PR on bare boilerplate

@0xGabi 0xGabi added the enhancement label Jul 31, 2019

@0xGabi 0xGabi requested a review from sohkai Jul 31, 2019

@0xGabi 0xGabi added this to In progress in Aragon Mesh Team via automation Jul 31, 2019

@sohkai

sohkai approved these changes Aug 1, 2019

Copy link
Member

left a comment

LGTM.

It will only include the minimum necessary files (manifest.json, artifact.json and code.sol).

Does it automatically include the manifest.json now? I remember before it wasn't.

manifest.json Outdated Show resolved Hide resolved
manifest.json Outdated Show resolved Hide resolved

0xGabi and others added some commits Aug 1, 2019

Update manifest.json
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
Update manifest.json
Co-Authored-By: Brett Sun <qisheng.brett.sun@gmail.com>
@0xGabi

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Yes it does 👍

@0xGabi 0xGabi merged commit 405da7a into aragon:master Aug 1, 2019

2 checks passed

WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

Aragon Mesh Team automation moved this from In progress to Done Aug 1, 2019

@0xGabi 0xGabi deleted the 0xGabi:chore/update-to-new-publish-script branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.