Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staging environment #78

Merged
merged 3 commits into from Oct 14, 2019

Conversation

@0xGabi
Copy link
Member

commented Sep 18, 2019

TODO:

  • Deploy registries on Staging
@0xGabi 0xGabi added the enhancement label Sep 18, 2019
@0xGabi 0xGabi requested review from ajsantander and sohkai Sep 18, 2019
arapp.json Outdated
"ropsten": {
"registry": "0x6afe2cacee211ea9179992f89dc61ff25c61e923",
"appName": "placeholder-app-name.open.aragonpm.eth",
"wsRPC": "wss://ropsten.infura.io/ws",

This comment has been minimized.

Copy link
@0xGabi

0xGabi Sep 18, 2019

Author Member

@sohkai Is there a Ropsten Aragon node?

arapp.json Show resolved Hide resolved
arapp.json Outdated
"mainnet": {
"registry": "0x314159265dd8dbb310642f98f50c066173c1259b",
"appName": "placeholder-app-name.open.aragonpm.eth",
"wsRPC": "wss://mainnet.eth.aragon.network/ws",
"network": "mainnet"
},
"ropsten": {
"registry": "0x6afe2cacee211ea9179992f89dc61ff25c61e923",

This comment has been minimized.

This comment has been minimized.

Copy link
@0xGabi

0xGabi Sep 24, 2019

Author Member

This one seems right 🤔

Copy link
Member

left a comment

@0xGabi I'm not sure I would include these environments in the boilerplate.

Staging we could make a case for, if we wanted to advertise it more as a throwaway environment that users could experiment with.

Ropsten we shouldn't advertise (at least at the moment); it's not meant to be fully supported and is only used for specific test integrations with some users.

@0xGabi

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

Perfect, make sense. I'll remove Ropsten.

In my experience so far seems that having a staging environment is useful as a step in the development workflow specially right now that most of the user testing is been done on Rinkeby

@sohkai
sohkai approved these changes Oct 9, 2019
@sohkai sohkai changed the title Add staging and ropsten Add staging environment Oct 14, 2019
@sohkai sohkai merged commit 78ba9a7 into aragon:master Oct 14, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.