New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CounterApp and testing not working #6

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@ottodevs
Copy link
Contributor

ottodevs commented Jul 22, 2018

  • Closes #4: The test problem was produced by a bad import naming causing test script unable to find the contract.
  • Closes #5: The CounterApp malfunction was caused by an old parcel version not producing the right dist/script.js so the app couldn't communicate with the smart contract.
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Jul 22, 2018

CLA assistant check
All committers have signed the CLA.

@luisivan luisivan requested a review from izqui Jul 23, 2018

@sohkai

This comment has been minimized.

Copy link
Member

sohkai commented Jul 23, 2018

Awesome work @ottodevs!

@sohkai

sohkai approved these changes Jul 23, 2018

@sohkai sohkai merged commit 0b0cf06 into aragon:master Jul 23, 2018

1 check passed

license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment