Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityBadge: focus ring on compact version can look cut off #374

Open
sohkai opened this issue May 15, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented May 15, 2019

Screen Shot 2019-05-15 at 1 29 54 PM

Since these are used as inline items, we may want to remove or reduce the size of the focus ring around them.

@sohkai sohkai added the bug label May 15, 2019

@bpierre

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Removing would break keyboard navigation so I wouldn’t consider it an option, but I see two things here:

  • For this component specifically, we should ensure the vertical lines of the outline land a bit more on the inside.
  • Ideally, every time we use overflow: hidden (or have a component positioned next to the viewport limits), we should either ensure that there is enough space to not cut the outline, or slightly adapt the focus ring so that it doesn’t get outside (e.g. for the top of MenuPanel in the Aragon client).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.