Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityBadge: avoid rendering as <button> if `badgeOnly` is set #448

Open
sohkai opened this issue Aug 11, 2019 · 0 comments

Comments

@sohkai
Copy link
Member

commented Aug 11, 2019

We use badgeOnly in places already nested by a <button>, such as in Autocomplete usages.

In these cases, because IdentityBadge also renders a <button>, we get an invalid DOM nesting (<button>s cannot be nested in <button>s). Moreover, the IdentityBadge does not really act as a button when it is in badgeOnly mode.

@sohkai sohkai added the bug label Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.