New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to styled-components v4 #208

Merged
merged 12 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@sistemico
Copy link

sistemico commented Sep 27, 2018

No description provided.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Sep 27, 2018

CLA assistant check
All committers have signed the CLA.

@sohkai sohkai requested a review from bpierre Sep 27, 2018

@bpierre

This comment has been minimized.

Copy link
Member

bpierre commented Sep 28, 2018

@sistemico Thanks for contributing! Is it ready to be reviewed?

@sistemico

This comment has been minimized.

Copy link

sistemico commented Sep 28, 2018

Yes, it's ready to get some feedback. Feel free to review it and let me know about any changes. Thanks!

@sistemico sistemico force-pushed the protofire:styled-components-v4 branch from 13c5911 to cfa2872 Oct 18, 2018

@sistemico

This comment has been minimized.

Copy link

sistemico commented Oct 18, 2018

Now that version 4 came out of beta1 and it's the new stable version, this migration is updated to latest and ready to see the light of day

  1. https://medium.com/styled-components/styled-components-v4-new-final-finalest-for-real-final-final-psd-fa4d83398a77

sistemico and others added some commits Oct 18, 2018

@bpierre bpierre changed the base branch from master to next Oct 22, 2018

@bpierre
Copy link
Member

bpierre left a comment

Excellent, thank you @sistemico! 💯 🎉

I am going to merge it in next so we can publish it while making sure master stays stable and easy to update for the next couple of weeks.

{ url: asset(overpassRegularWoff2), format: 'woff2', enable: true },
{ url: asset(overpassRegularWoff), format: 'woff', enable: legacyFonts },
])};
src: ${props => fontSrc(fontFamily['Regular'], props)};

This comment has been minimized.

@bpierre

bpierre Oct 22, 2018

Member

That’s nicer! 😊

@bpierre bpierre merged commit d5fa195 into aragon:next Oct 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

bpierre added a commit that referenced this pull request Oct 29, 2018

Migrating to styled-components v4 (#208)
- Upgrade to styled-components v4.
- Replace injectGlobal API with new createGlobalStyle helper component.
- Remove usages of .extend API.
- Use normal ref instead of innerRef.
- Update babel-plugin-styled-components to the latest version.
- Fix global styles injection.
- Fix devbox build.

@sistemico sistemico deleted the protofire:styled-components-v4 branch Oct 30, 2018

bpierre added a commit that referenced this pull request Dec 1, 2018

Migrate to styled components v4 (#208 + #250)
- Upgrade to styled-components v4.
- Replace injectGlobal API with new createGlobalStyle helper component.
- Remove usages of .extend API.
- Use normal ref instead of innerRef.
- Update babel-plugin-styled-components to the latest version.
- Fix global styles injection.
- Fix devbox build.
- Use the `as` prop rather than withComponent().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment