New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publicUrl a required prop #255

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@2color
Copy link
Contributor

2color commented Nov 19, 2018

Prevent strange errors when publicUrl isn't passed.

Make publicUrl a required prop
Otherwise strange errors show up when publicUrl isn't passed.

@bpierre bpierre self-requested a review Nov 20, 2018

@bpierre
Copy link
Member

bpierre left a comment

Thanks @2color!

@bpierre bpierre merged commit 3f3e0a8 into aragon:master Nov 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment