Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance blockexplorer url #368

Merged
merged 3 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented May 8, 2019

Fixes #367

The IdentityBadge without a link:

Screen Shot 2019-05-08 at 11 58 04 AM

sohkai added some commits May 8, 2019

@sohkai sohkai requested a review from bpierre May 8, 2019

@bpierre

bpierre approved these changes May 8, 2019

@@ -8,6 +8,7 @@ const ETHERSCAN_NETWORK_TYPES = new Map([
['kovan', 'kovan.'],
['rinkeby', 'rinkeby.'],
['ropsten', 'ropsten.'],
['goerli', 'goerli.'],

This comment has been minimized.

Copy link
@bpierre

@sohkai sohkai merged commit 1c55ea5 into master May 8, 2019

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the enhance-blockexplorer-url branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.