Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown: add placeholder, renderLabel and wide props #436

Merged
merged 7 commits into from Aug 7, 2019

Conversation

@deamme
Copy link
Contributor

commented Aug 6, 2019

Changes

  • label is going to be deprecated and is now renamed to placeholder.
  • renderLabel prop has been added to force display. An example use case is to force display a shorten address instead of the whole address.
  • wide prop has been added again (was missing since the newstyle implementation).
  • Update docs.

@auto-assign auto-assign bot requested a review from bpierre Aug 6, 2019

@bpierre bpierre requested a review from AquiGorka Aug 6, 2019

bpierre added some commits Aug 6, 2019

@bpierre

bpierre approved these changes Aug 6, 2019

Copy link
Member

left a comment

Thank you Deam! 💯 🙏 🎉

I added a few things:

  • Default renderLabel().
  • Documentation update.
  • Add support for wide again (this prop was missing since the newstyle version).

@deamme @AquiGorka All good for me now! Could you check one last time, especially the commit adding support for wide? Thanks in advance! 🤗

@bpierre bpierre changed the title DropDown: added placeholder and renderLabel props DropDown: add placeholder, renderLabel and wide props Aug 6, 2019

@deamme

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

@bpierre Looks good to me!

@sohkai
Copy link
Member

left a comment

So excited to use wide 🎉!

src/components/DropDown/DropDown.js Outdated Show resolved Hide resolved
src/components/DropDown/DropDown.js Outdated Show resolved Hide resolved
@AquiGorka
Copy link
Member

left a comment

🎉 🎉 Thanks @deamme

@bpierre bpierre merged commit f36c89f into aragon:newstyle Aug 7, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.