Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution: add renderFullLegendItem() #440

Merged
merged 4 commits into from Aug 9, 2019

Conversation

@bpierre
Copy link
Member

commented Aug 9, 2019

This change makes it possible to deprecate PartitionBar, which is now using Distribution internally.

bpierre added some commits Aug 8, 2019

@bpierre bpierre requested review from AquiGorka and sohkai Aug 9, 2019

@sohkai

sohkai approved these changes Aug 9, 2019

Copy link
Member

left a comment

LGTM, there are a couple changes to the flex grows / shrinks in the legend items but I assume those will also fix some of the alignment problems PartitionBar had?

@bpierre

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

@sohkai Yes, I added some spacing between the left part and the percentage, which required some tweaks to keep text-overflow: ellipsis working.

@bpierre bpierre merged commit ed0b9fa into newstyle Aug 9, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@bpierre bpierre deleted the deprecate-partition-bar branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.