Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3: always lowercase tokenIconUrl addresses when creating icon URL #444

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@sohkai
Copy link
Member

commented Aug 11, 2019

TrustWallet's repo has the token addresses all lower cased, so we should do the same to tokenIconUrl()'s address argument :).

@auto-assign auto-assign bot requested a review from bpierre Aug 11, 2019

@sohkai sohkai merged commit 56a02f7 into newstyle Aug 11, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the fix-token-icon branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.