Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: newstyle tweaks #447

Merged
merged 3 commits into from Aug 11, 2019

Conversation

@bpierre
Copy link
Member

commented Aug 11, 2019

  • Use a border rather than a shadow, for the button and the popup menu.
  • Use theme.surfacePressed for the pressed state of the button.
  • For the selected mode, use theme.selected (rather than theme.accent).
  • Do not scale the popover during the opening transition.
  • Popover now passes its props down to the main element.

bpierre added some commits Aug 11, 2019

DropDown: new style tweaks
- Use a border rather than a shadow, for the button and the popup menu.
- Use theme.surfacePressed for the pressed state of the button.
- For the selected mode, use theme.selected (rather than theme.accent).
- Do not scale the popover during the transition.
- Popover now passes its props down to the main element.

@bpierre bpierre requested a review from sohkai Aug 11, 2019

@sohkai

sohkai approved these changes Aug 11, 2019

Copy link
Member

left a comment

LGTM!

@bpierre bpierre merged commit 9bfa981 into newstyle Aug 11, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@bpierre bpierre deleted the newstyle-dropdown-tweaks branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.