Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Link #450

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@bpierre
Copy link
Member

commented Aug 12, 2019

Link combines the features of ExternalLink and SafeLink into a single component.

Add Link
Link combines the features of ExternalLink and SafeLink into a single
component.

@bpierre bpierre requested review from AquiGorka and sohkai Aug 12, 2019

passedProps._target = 'blank'
}

if (unsafe) {

This comment has been minimized.

Copy link
@AquiGorka

AquiGorka Aug 12, 2019

Member

Do we really need this?

This comment has been minimized.

Copy link
@bpierre

bpierre Aug 12, 2019

Author Member

Good point yes! Users can set rel themselves to achieve that, especially because it’s not really recommended. 👍

@AquiGorka
Copy link
Member

left a comment

🔗 :safe: ❤️

bpierre added some commits Aug 12, 2019

Link: remove unsafe
The rel prop can be used to achieve the same.
@bpierre bpierre referenced this pull request Aug 12, 2019
@sohkai

sohkai approved these changes Aug 12, 2019

Copy link
Member

left a comment

LGTM!

@bpierre bpierre merged commit c9cd582 into newstyle Aug 12, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the link branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.