Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IconStarFilled #453

Merged
merged 4 commits into from Aug 12, 2019

Conversation

@bpierre
Copy link
Member

commented Aug 12, 2019

bpierre added some commits Aug 12, 2019

@bpierre bpierre requested review from AquiGorka, sohkai and owisixseven Aug 12, 2019

@bpierre bpierre changed the base branch from master to newstyle Aug 12, 2019

bpierre added some commits Aug 12, 2019

@sohkai

sohkai approved these changes Aug 12, 2019

Copy link
Member

left a comment

LGTM.

Our tooling doesn't really support it, but I imagine it would have been nice to add this as a "filled" mode to IconStar 🤷‍♂

@AquiGorka
Copy link
Member

left a comment

⭐️ 🌟 🌟

@bpierre

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Our tooling doesn't really support it, but I imagine it would have been nice to add this as a "filled" mode to IconStar 🤷‍♂

It’s something we could do, but I also like the idea of having a common API for all the Icon prefixed components, rather than having to explain that some are special.

@bpierre bpierre merged commit 49e5aad into newstyle Aug 12, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@bpierre bpierre deleted the icon-star-filled branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.