Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field: use new theme / text styles #457

Merged
merged 3 commits into from Aug 13, 2019

Conversation

@bpierre
Copy link
Member

commented Aug 12, 2019

No description provided.

@bpierre bpierre requested review from AquiGorka and sohkai Aug 12, 2019

<StyledField {...props}>
<div
css={`
margin-bottom: ${3 * GU}px;

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 13, 2019

Member

Not sure on this bottom margin; the designs feel like they may be smaller than before (we previously had 20px), so maybe 16px? cc @dizzypaty

This change is also a bit scary since we don't always use Field directly and will have to update various self-set margins in the client and apps.

This comment has been minimized.

Copy link
@bpierre

bpierre Aug 13, 2019

Author Member

From what I can see, the new margin is 24px:

This change is also a bit scary since we don't always use Field directly and will have to update various self-set margins in the client and apps.

I don’t think this is more of a problem here than in other places? We have been fixing the spacing as we go in various places, from using multiples of 10 to multiples of 8, and I think we should continue to do so. If a space look wrong, it probably means that we need to update it to GU units 😄

This comment has been minimized.

Copy link
@owisixseven

owisixseven Aug 13, 2019

The margin here is 24px!

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 13, 2019

Member

I don’t think this is more of a problem here than in other places?

Yes... it's just that we haven't used Field consistently and thus have a lot of places where we've used 20px that we should update (and haven't yet).

This comment has been minimized.

Copy link
@bpierre

bpierre Aug 13, 2019

Author Member

Yes I think we should do some grepping for 5px, 10px, 15px, 20px etc. in the different projects at some point, to make sure everything is up to date. Starting with the apps shouldn’t be too difficult.

bpierre added some commits Aug 13, 2019

@sohkai

sohkai approved these changes Aug 13, 2019

@bpierre bpierre merged commit 140ec1e into newstyle Aug 13, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the newstyle-field branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.