Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataview tweaks #463

Merged
merged 3 commits into from Aug 13, 2019

Conversation

@bpierre
Copy link
Member

commented Aug 13, 2019

Changes:

  • Pass the current mode to the render functions.
  • In table mode, let cells use the full width.

bpierre added some commits Aug 13, 2019

@bpierre bpierre requested review from AquiGorka and sohkai Aug 13, 2019

@sohkai

sohkai approved these changes Aug 13, 2019

Copy link
Member

left a comment

LGTM

justify-content: ${`flex-${align}`};
`}
>
<div css="display: flex">{content}</div>

This comment has been minimized.

Copy link
@sohkai

sohkai Aug 13, 2019

Member

Hope this doesn't break any of the current apps 🤞

This comment has been minimized.

Copy link
@bpierre

bpierre Aug 13, 2019

Author Member

It should be fine ® 🤞

This comment has been minimized.

Copy link
@AquiGorka

AquiGorka Aug 13, 2019

Member

For that sake we could add flex-direction: column to mimic a traditional block container.

This comment has been minimized.

Copy link
@bpierre

bpierre Aug 13, 2019

Author Member

The idea of using flex-direction: row is because DataView’s table rows have a fixed height, making the vertical space is quite limited. It reinforces the recommended way to lay out things (horizontally).

@bpierre bpierre merged commit 90c11dd into newstyle Aug 13, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details

@bpierre bpierre deleted the dataview-tweaks branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.