Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: adapt to the new theme #560

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 3, 2019

Use the new theme colors + pass the extra props (so we can disable the padding when needed).

The next change will add a “full width” mode to correspond to the new style, where the left side of the handle stops on the left side of the bar, and vice versa.

Slider: adapt to the new theme
- New colors.
- Pass the extra props.

@bpierre bpierre requested review from AquiGorka and sohkai Sep 3, 2019

@sohkai
sohkai approved these changes Sep 3, 2019
Copy link
Member

left a comment

LGTM

@bpierre bpierre merged commit ef2eaaf into newstyle Sep 3, 2019

4 of 5 checks passed

License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the newstyle-slider-theme branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.