Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: fix the shadow of the pressed state #561

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 3, 2019

The Button shadow has been changed at some point, but without adapting its pressed state. This change fixes that.

@bpierre bpierre requested review from AquiGorka and sohkai Sep 3, 2019

@sohkai
sohkai approved these changes Sep 3, 2019
@AquiGorka
Copy link
Member

left a comment

These should come from some BOX_SHADOW_ACTIVE kind of var down the road no?

@bpierre

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

@AquiGorka Yes I’ve been resisting having shadows defined anywhere until we figure out what we need exactly, but we should start working with @dizzypaty @owisixseven to define the different values we use across the different components.

We should probably store them as number values, so they can be used in different contexts (box shadow, multiple box shadows, transitions, drop-shadow), and per level of elevation. We could also have a box-shadow CSS utility that would know the different names, because it is the most common use case:

<div
  css={`
    // 100 would be the first elevation level,
    // 200 the next one etc. (like font weights)
    ${shadow('100')};
  `}
/>

@bpierre bpierre merged commit 3100ff7 into newstyle Sep 3, 2019

4 of 5 checks passed

License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the button-shadow-fix branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.