Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BadgeBase #565

Merged
merged 11 commits into from Sep 4, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 3, 2019

Adds BadgeBase to consolidate the logic / styling of different badges. Also introduces:

  • IdentityBadge: disabled state
  • TokenBadge: badge only, compact, and disabled state
  • TransactionBadge: disabled state

The name conflicts a bit with the deprecated Badge, but I think this is OK (users should think of that as Tags now).

@auto-assign auto-assign bot requested a review from bpierre Sep 3, 2019

@bpierre

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

@bpierre What do you think about consolidating all of IdentityBadge, TokenBadge, TransactionBadge, and AppBadge via this BadgeBase?

That’s a great idea yes!

The name conflicts a bit with the deprecated Badge, but I think this is OK (users should think of that as Tags now).

Agreed. 👍

sohkai added 8 commits Sep 4, 2019
@bpierre
bpierre approved these changes Sep 4, 2019
sohkai added 2 commits Sep 4, 2019

@sohkai sohkai merged commit fa8ab61 into newstyle Sep 4, 2019

5 checks passed

License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the badgebase branch Sep 4, 2019

sohkai added a commit that referenced this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.