Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown: update caret colour to surfaceIcon #573

Merged
merged 3 commits into from Sep 4, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 4, 2019

As discussed with @dizzypaty

@sohkai sohkai requested a review from bpierre Sep 4, 2019

color: ${closedWithChanges && !disabled ? theme.accent : 'inherit'};
color: ${closedWithChanges && !disabled
? theme.accent
: theme.surfaceIcon};

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 4, 2019

Member

We should also use theme.disabledIcon when disabled (same result but it might be different in other themes).

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 4, 2019

Author Member

Done in 362ff90, this is how it looks:

Screen Shot 2019-09-04 at 10 32 12 PM

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 4, 2019

Member

Just added a code suggestion to use disabledIcon rather than disabledContent, all good otherwise! ☝️

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 4, 2019

Author Member

Ahh missed that I should be using disabledIcon! Thanks!

Update src/components/DropDown/DropDown.js
Co-Authored-By: Pierre Bertet <hello@pierre.world>

@sohkai sohkai merged commit 1d918c8 into newstyle Sep 4, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the dropdown-fix-caret branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.