Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthIdenticon + BadgeBase fixes #583

Merged
merged 4 commits into from Sep 8, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 6, 2019

Fixes #338

  • EthIdenticon: fix border-radius on Chrome.
  • AddressField: use a <a> when read only.

@bpierre bpierre requested review from AquiGorka and sohkai Sep 6, 2019

bpierre added 3 commits Sep 6, 2019

@bpierre bpierre changed the title EthIdenticon: fix border-radius on Chrome EthIdenticon + BadgeBase fixes Sep 6, 2019

@sohkai
sohkai approved these changes Sep 8, 2019
// Fix an issue where the border-radius wasn’t visible on Blink browsers.
// See https://gist.github.com/ayamflow/b602ab436ac9f05660d9c15190f4fd7b
mask-image: linear-gradient(red, red);

This comment has been minimized.

Copy link
@sohkai

sohkai Sep 8, 2019

Member

Is this necessary if we do this in EthIdenticon?

This comment has been minimized.

Copy link
@bpierre

bpierre Sep 8, 2019

Author Member

Yes, because the border-radius is applied at the container level in that case (only on one side + can be replaced by another component).

@bpierre bpierre merged commit fb54062 into newstyle Sep 8, 2019

5 checks passed

License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the eth-identicon-border-radius-chrome branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.