Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropDown: fix a prop type error #588

Merged
merged 1 commit into from Sep 9, 2019

Conversation

@bpierre
Copy link
Member

commented Sep 9, 2019

No description provided.

@bpierre bpierre requested review from AquiGorka and sohkai Sep 9, 2019

@sohkai
sohkai approved these changes Sep 9, 2019
@sohkai

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

I think I may have made this change, as we started talking about the DropDown always having a header.

@bpierre bpierre merged commit 8d3046e into newstyle Sep 9, 2019

5 checks passed

License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the dropdown-prop-type-error branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.