Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppBadge: avoid appAddress warning if badgeOnly is set #589

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

The appAddress is only used in the AppBadge's popover, and this is disabled in badgeOnly mode.

@auto-assign auto-assign bot requested a review from bpierre Sep 10, 2019

@sohkai sohkai merged commit 5cb8309 into newstyle Sep 10, 2019

2 of 5 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the appbadge-avoid-warning-badgeonly branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.