Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: fix overflowing height and centering on Safari #592

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 10, 2019

Essentially reverts #582, but changes the align-items to align-content as a way of getting the centering to work on Safari.

@auto-assign auto-assign bot requested a review from bpierre Sep 10, 2019

@bpierre bpierre merged commit d440f0a into newstyle Sep 10, 2019

4 of 5 checks passed

License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the modal-centering-fix branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.