Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki redesign #492

Merged
merged 7 commits into from Aug 13, 2019

Conversation

@delfipolito
Copy link
Contributor

commented Aug 6, 2019

image

@sohkai sohkai referenced this pull request Aug 6, 2019

@delfipolito delfipolito requested review from sohkai and bpierre Aug 7, 2019

@sohkai

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

I think the sidebar's nested menus look a bit odd, especially since they contain some padding.

Would it be OK if they were the same font style as the others, but just with the arrow / caret to let users know it's a nested menu?

Screen Shot 2019-08-08 at 5 55 35 PM

@sohkai

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

The content's h4 and h5 look a bit odd, and I find the h5 style especially confusing (text transformed to be uppercase and it being larger than the h4):

Screen Shot 2019-08-08 at 5 57 28 PM

@sohkai

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

When a page starts with an h1 and is immediately followed by an h2, there is quite a lot of margins / padding applied that makes the page feel disconnected:

Screen Shot 2019-08-08 at 5 58 47 PM

@sohkai
Copy link
Member

left a comment

Really like the new nav bar 😍!

Noted down a couple of visual items that I thought could use some touching up. The biggest is definitely the nested sidebar menus.

delfipolito and others added some commits Aug 9, 2019

@sohkai

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

One last small thing with the navbar, the nested menus have a bit more margin/padding applied than the non-nested items, and it makes it look a bit unbalanced:

Screen Shot 2019-08-10 at 12 26 19 PM

What do you think about forcing them to use the same amount of padding?

@delfipolito delfipolito merged commit d995e04 into aragon:master Aug 13, 2019

3 checks passed

WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.