Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add message signing #276

Merged
merged 15 commits into from Apr 13, 2019

change requestingApp address naming

  • Loading branch information...
Schwartz10 committed Apr 9, 2019
commit 31701f5e183ce8e5dca4785da1d2843bb75f5297
@@ -780,10 +780,10 @@ export default class Aragon {
* @param {Array<Object>} params An object containing the address of the app and the message to be signed
This conversation was marked as resolved by Schwartz10

This comment has been minimized.

Copy link
@2color

2color Apr 10, 2019

Contributor
Suggested change
* @param {Array<Object>} params An object containing the address of the app and the message to be signed
* @param {string} message to be signed
* @param {string} requestingApp proxy address of requesting app
* @return {Promise<string>} signature hash
*/
signMessage (message, appAddress) {
signMessage (message, requestingApp) {
return new Promise((resolve, reject) => {
this.signatures.next({
appAddress,
requestingApp,
message,
accept (signatureHash) {
This conversation was marked as resolved by sohkai

This comment has been minimized.

Copy link
@2color

2color Apr 10, 2019

Contributor

@sohkai I thought the long term goal was to rename to resolve as we did with identity This is not critical for this PR but should be consistent.

Any preferences?

This comment has been minimized.

Copy link
@sohkai

sohkai Apr 10, 2019

Member

Ah yes, good catch. Let's rename this to resolve() 👍.

This conversation was marked as resolved by sohkai

This comment has been minimized.

Copy link
@2color

2color Apr 11, 2019

Contributor
Suggested change
accept (signatureHash) {
resolve (signatureHash) {
resolve(signatureHash)
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.