Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpc Messenger: dedupe message bus across requests #278

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

sohkai commented Apr 8, 2019

We used to create a new listener on the target each time provider.messages() was called, due to the fromEvent().

Now these requests are deduped and the results are multicasted to subscribers.

@sohkai sohkai requested a review from 2color Apr 8, 2019

@2color

2color approved these changes Apr 9, 2019

@sohkai sohkai merged commit 0aa5e04 into master Apr 9, 2019

4 checks passed

License Compliance All checks passed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the rpc-dedupe-message-filter branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.