Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @aragon/wrapper api cleanup #279

Merged
merged 3 commits into from Apr 13, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

sohkai commented Apr 11, 2019

With the breaking change in #267, this is a good chance to consolidate the API a bit 馃槃. See aragon/aragon#690 for the corresponding PR in aragon/aragon.

Also adds a few tests to the observables requiring "callbacks" (e.g. performTransactionPath())

sohkai added some commits Apr 11, 2019

@sohkai sohkai requested a review from 2color Apr 11, 2019

@2color

2color approved these changes Apr 11, 2019

Copy link
Contributor

2color left a comment

馃檶馃徏馃憦馃徏

@sohkai sohkai merged commit c15e02c into master Apr 13, 2019

1 of 4 checks passed

License Compliance FOSSA is analyzing this commit
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the api-cleanup branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.