Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3: upgrade to latest v1 #334

Merged
merged 4 commits into from Sep 1, 2019

Conversation

@topocount
Copy link
Contributor

commented Jul 3, 2019

Changes
I bumped the web3 dependency up to release 37 from release 33. I've tested and verified that this will support the ability to return tuples from contracts without any further modifications.

@auto-assign auto-assign bot requested review from 2color and sohkai Jul 3, 2019

@topocount topocount referenced this pull request Jul 3, 2019
@topocount

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

@sohkai do you know of any workarounds for the increased size of this web3 release? Or will we have to bump the size limit up?

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

@topocount We'll likely just up the size limit; there's not much we can do here.

Before this gets merged I'd like to test it (and up all the pinned versions of web3.js everywhere to beta.37).

@topocount

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Before this gets merged I'd like to test it (and up all the pinned versions of web3.js everywhere to beta.37).

Before submitting this, I tested this PR, along with a version of the client running web3-1.0r37 with the TPS test script and didn't run into any issues. However, while our apps do use a fair bit of the client and wrapper's functionality, not all of it was tested there.

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

It occurred to me that it's likely the additional size is because we've pinned web3.js to other versions in @aragon/wrapper's dependencies (likely @aragon/apm, which I'd like to remove anyway). This will likely not be a problem once we bump those as well.

@topocount

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

It occurred to me that it's likely the additional size is because we've pinned web3.js to other versions in @aragon/wrapper's dependencies (likely @aragon/apm, which I'd like to remove anyway). This will likely not be a problem once we bump those as well.

@sohkai aside from what's quoted above, is there anything remaining you'd need me to do to get this merged?

@sohkai

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

@topocount Nope, it’s been mostly on me; I want to remove the apm.js dependency this week and then I’ll have this all tested and upgraded through the stack.

@stale stale bot added the abandoned label Aug 29, 2019

@aragon aragon deleted a comment from stale bot Aug 29, 2019

@stale stale bot removed the abandoned label Aug 29, 2019

@sohkai sohkai referenced this pull request Sep 1, 2019
1 of 1 task complete

@sohkai sohkai changed the title upgrade web3 to release 37 Web3: upgrade to latest v1 Sep 1, 2019

topocount and others added 3 commits Jul 2, 2019

@sohkai sohkai force-pushed the AutarkLabs:update-web3-to-r33 branch from e6c1638 to 40ec9b4 Sep 1, 2019

@sohkai
sohkai approved these changes Sep 1, 2019
Copy link
Member

left a comment

@topocount I've updated the dependencies to be based on the latest v1. Tested and most things looked good, with the exception of the current onboarding (fixed in aragon/aragon#947).

I've also updated radspec as that was also pinning the web3 dependency.

@sohkai sohkai merged commit 66d3a99 into aragon:master Sep 1, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP Ready for review
Details
@welcome

This comment has been minimized.

Copy link

commented Sep 1, 2019

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

@chadoh chadoh deleted the AutarkLabs:update-web3-to-r33 branch Sep 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.