Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions: Decode nested forwarding paths #337

Merged
merged 2 commits into from Jul 9, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented Jul 8, 2019

This PR aims to improve the way we decode transactions path to support nested transaction paths.
This will help describing complex chained forwarding asynchronous actions, for example, a voting proposal that will trigger another voting proposal to finally execute sth in case it is successful.

@facuspagnuolo facuspagnuolo requested a review from sohkai Jul 8, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jul 8, 2019

@auto-assign auto-assign bot requested a review from 2color Jul 8, 2019

@welcome

This comment has been minimized.

Copy link

commented Jul 8, 2019

Thanks for opening this pull request! Someone will review it soon 🔍

@sohkai

sohkai approved these changes Jul 8, 2019

Copy link
Member

left a comment

❤️ ❤️ Looking really good!

Show resolved Hide resolved packages/aragon-wrapper/src/evmscript/index.js Outdated
Show resolved Hide resolved packages/aragon-wrapper/src/index.js
Show resolved Hide resolved packages/aragon-wrapper/src/index.js
Show resolved Hide resolved packages/aragon-wrapper/src/index.test.js Outdated
Show resolved Hide resolved packages/aragon-wrapper/src/index.js Outdated

@facuspagnuolo facuspagnuolo force-pushed the describe_nested_transaction_paths branch from 33bcc36 to 3eb8af5 Jul 8, 2019

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Thanks @sohkai for reviewing! I already addressed your comments if you wanna take another look 🙌

@lkngtn lkngtn referenced this pull request Jul 8, 2019

Open

Approvals App #131

5 of 7 tasks complete

@facuspagnuolo facuspagnuolo merged commit 1f3af89 into master Jul 9, 2019

11 of 12 checks passed

License Compliance 1 issues found
Details
WIP Ready for review
Details
bootstrap bootstrap
Details
build build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.7%) to 50.868%
Details
install install
Details
license/cla Contributor License Agreement is signed.
Details
lint lint
Details
size size
Details
test test
Details

@facuspagnuolo facuspagnuolo deleted the describe_nested_transaction_paths branch Jul 9, 2019

@welcome

This comment has been minimized.

Copy link

commented Jul 9, 2019

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.