Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: cosmetic changes to removeLocalIdentities() #342

Merged
merged 1 commit into from Jul 10, 2019

Conversation

Projects
None yet
1 participant
@sohkai
Copy link
Member

commented Jul 10, 2019

No description provided.

@auto-assign auto-assign bot requested a review from 2color Jul 10, 2019

@@ -957,12 +957,13 @@ export default class Aragon {
/**
* Remove selected local identities
*
* @param {Array<Address>} addresses The addresses to be removed from the local identity provider
* @param {Array<string>} addresses The addresses to be removed from the local identity provider

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 10, 2019

Author Member

I think we generally keep addresses to a string type in the documentation.

@sohkai sohkai merged commit 09ab37c into master Jul 10, 2019

11 of 12 checks passed

License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
bootstrap bootstrap
Details
build build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 50.868%
Details
install install
Details
license/cla Contributor License Agreement is signed.
Details
lint lint
Details
size size
Details
test test
Details

@delete-merged-branch delete-merged-branch bot deleted the cosmetic-delete-local-label branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.