Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: add ability to apply token approval pretransactions to forwarders requiring fees #344

Merged
merged 3 commits into from Jul 11, 2019

Conversation

Projects
None yet
2 participants
@sohkai
Copy link
Member

commented Jul 10, 2019

Adds the ability to attach pretransactions to an initial forwarder that requires fees (e.g. a Tollgate).

Requires a new release of aragonOS (aragon/aragonOS#539).

@auto-assign auto-assign bot requested a review from 2color Jul 10, 2019

}

// Approve the app (destination) unless an spender is passed to approve a different contract
const approveSpender = spender || destination

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 10, 2019

Author Member

Oops, this was actually done a bit too late; we should've used the spender when checking the initial allowance.

@2color

2color approved these changes Jul 11, 2019

sohkai added some commits Jul 11, 2019

@sohkai sohkai merged commit c25a1f1 into master Jul 11, 2019

10 of 12 checks passed

coverage/coveralls Coverage decreased (-0.8%) to 50.261%
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
bootstrap bootstrap
Details
build build
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
install install
Details
license/cla Contributor License Agreement is signed.
Details
lint lint
Details
size size
Details
test test
Details

@delete-merged-branch delete-merged-branch bot deleted the forwarder-fee-pretransaction branch Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.