Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: hotfix isForwarder() check on apps #372

Merged
merged 2 commits into from Sep 1, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 1, 2019

The isForwarder() check on each app was broken from the web3@1 upgrade (see underlying issue). This hotfixes the check so that we override it to be false if the app wasn't compiled with IForwarder.

Note that this isn't 100% full-proof; an app could, within reason, dynamically decide to start or stop being a forwarder at one point or another. Also note that having every app be a forwarder should not break anything, it just makes the transaction pathing algorithm more complicated and resource intensive.

Given that no app (that I know of) dynamically switches from being a forwarder to not, I sided with not degrading transaction pathing performance.

@auto-assign auto-assign bot requested a review from 2color Sep 1, 2019

@sohkai sohkai merged commit 508feee into master Sep 1, 2019

12 checks passed

bootstrap bootstrap
Details
build build
Details
install install
Details
lint lint
Details
size size
Details
test test
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on fix-isforwarder-check at 55.412%
Details
license/cla Contributor License Agreement is signed.
Details

@delete-merged-branch delete-merged-branch bot deleted the fix-isforwarder-check branch Sep 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.