Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: rename apps apis to installedApps() and currentApp() #374

Merged
merged 3 commits into from Sep 2, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 2, 2019

See discussion in #352 (comment).

Deprecates the old getApps() behaviour and replaces it entirely with installedApps().

Also renames getCurrentApp() to currentApp() for consistency.

  • I have updated the associated documentation with my changes

@auto-assign auto-assign bot requested a review from 2color Sep 2, 2019

sohkai added 2 commits Sep 2, 2019
@sohkai sohkai referenced this pull request Sep 2, 2019
1 of 1 task complete

@sohkai sohkai changed the title API: rename getApps() and getCurrentApp() to installedApps() and currentApp() API: rename apps apis to installedApps() and currentApp() Sep 2, 2019

@sohkai sohkai merged commit e6ff309 into master Sep 2, 2019

10 of 12 checks passed

bootstrap bootstrap
Details
build build
Details
install install
Details
lint lint
Details
size size
Details
test test
Details
coverage/coveralls Coverage decreased (-0.03%) to 55.481%
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the api-apps-rename branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.