Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: allow IPFS fetch timeout to be parameterized #386

Merged
merged 1 commit into from Sep 8, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 8, 2019

Allows the IPFS timeout for fetching aragonPM artifacts be parameterized by users through the wrapper's options.apm.ipfs.fetchTimeout optional parameter. Like before, defaults to 10s.

cc @0xGabi

  • I have updated the associated documentation with my changes

@auto-assign auto-assign bot requested a review from 2color Sep 8, 2019

@sohkai sohkai merged commit c7ff8b6 into master Sep 8, 2019

11 of 12 checks passed

bootstrap bootstrap
Details
build build
Details
install install
Details
lint lint
Details
size size
Details
test test
Details
coverage/coveralls Coverage decreased (-0.2%) to 54.443%
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the wrapper-parameterize-ipfs-fetch-timeout branch Sep 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.