Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: remove handlers for templates #387

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@sohkai
Copy link
Member

commented Sep 8, 2019

Removes the template handlers from @aragon/wrapper, since all of this logic will be moving to be handled in the client instead. In particular, there is not much reason for @aragon/wrapper to handle this since templates are generic and a frontend only needs the ABI to create transactions (of which the apm and ensResolve helpers being exported can already accomplish).

Also exports the getRecommendedGasLimit() utility. Ideally these types of utilities (similar to the ENS resolution and aragonPM utilities) would be exported from a different package or location entirely, but for now we can include these here for convenience.

  • I have updated the associated documentation with my changes
sohkai added 2 commits Sep 8, 2019

@auto-assign auto-assign bot requested a review from 2color Sep 8, 2019

@sohkai sohkai merged commit 1d74748 into master Sep 9, 2019

12 checks passed

bootstrap bootstrap
Details
build build
Details
install install
Details
lint lint
Details
size size
Details
test test
Details
License Compliance All checks passed.
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.8%) to 56.183%
Details
license/cla Contributor License Agreement is signed.
Details

@sohkai sohkai deleted the wrapper-remove-templates branch Sep 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.