Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: clarify calculateTransactionPath() error when destination is not installed #390

Merged
merged 3 commits into from Oct 2, 2019

Conversation

@macor161
Copy link
Contributor

commented Sep 26, 2019

Changes

Small change to throw a more specific error message when app is not found.

The previous error was thrown in createDirectTransactionForApp and was a little bit misleading: Could not create transaction due to missing app artifact. People often thought it was a problem related to IPFS.

  • (N/A) I have updated the associated documentation with my changes
@auto-assign auto-assign bot requested review from 2color and sohkai Sep 26, 2019
macor161 and others added 2 commits Sep 26, 2019
…tion path
@sohkai
sohkai approved these changes Oct 2, 2019
Copy link
Member

left a comment

LGTM, thanks @macor161!

Although I am curious how this case was hit; I imagine in the CLI users were giving the destination address as an argument?

@sohkai sohkai changed the title calculateTransactionPath error message Wrapper: clarify calculateTransactionPath() error when destination is not installed Oct 2, 2019
@sohkai sohkai merged commit cf340e8 into aragon:master Oct 2, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 55.462%
Details
license/cla Contributor License Agreement is signed.
Details
@macor161

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

@sohkai Thanks for the adjustment! Yes exactly, and also when trying to execute a function on an app that doesn't have any permissions.

@macor161 macor161 deleted the macor161:new-error branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.