Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper: use addressesEqual() in more places where an address comparison happens #394

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@sohkai
Copy link
Member

commented Oct 2, 2019

Forgot to use the addressesEqual() utility in these cases previously.

The only real problem that could have occurred would have been the final forwarder and sender check, since both of those are outside parameters given by users, but it's good to be consistent everywhere else we do address comparisons.

…son happens
@auto-assign auto-assign bot requested a review from 2color Oct 2, 2019
@sohkai sohkai merged commit 12a71aa into master Oct 2, 2019
10 of 11 checks passed
10 of 11 checks passed
bootstrap bootstrap
Details
build build
Details
install install
Details
lint lint
Details
size size
Details
test test
Details
License Compliance FOSSA is analyzing this commit
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 55.462%
Details
@sohkai sohkai deleted the use-addressesequal branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.