New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifiers #77

Merged
merged 6 commits into from Mar 14, 2018

Conversation

Projects
None yet
2 participants
@onbjerg
Contributor

onbjerg commented Mar 14, 2018

This PR allows apps to feel unique 馃槶

Usage

app.identify(identifier) // => nothing

Wrappers can access apps' identifiers (might be undefined!) on the identifier key of the apps array emitted by the wrapper.apps observable.

onbjerg added some commits Mar 13, 2018

@onbjerg onbjerg requested review from bpierre and sohkai Mar 14, 2018

@sohkai

Not 100% sure how to best use this to set the identifiers, but probably in the background script (when it starts, it'll determine what instance it's on, e.g. the voting token's symbol, and set it).

Show outdated Hide outdated packages/aragon-wrapper/src/index.js

onbjerg added some commits Mar 14, 2018

@onbjerg

This comment has been minimized.

Show comment
Hide comment
@onbjerg

onbjerg Mar 14, 2018

Contributor

@sohkai Fixed in 6e4b595. Tested this locally in sandbox and it does attach identifiers 馃帀

Let me know if you have other comments, or else I'll merge

Contributor

onbjerg commented Mar 14, 2018

@sohkai Fixed in 6e4b595. Tested this locally in sandbox and it does attach identifiers 馃帀

Let me know if you have other comments, or else I'll merge

@sohkai

sohkai approved these changes Mar 14, 2018

馃帀

Show outdated Hide outdated packages/aragon-wrapper/src/index.js

@onbjerg onbjerg merged commit 344ded6 into master Mar 14, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@onbjerg onbjerg deleted the identifiers branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment