Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: only list forwarders when assigning permissions to apps #692

Open
sohkai opened this Issue Apr 12, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@sohkai
Copy link
Member

sohkai commented Apr 12, 2019

For now, we can safely assume that if an app isn't a forwarder, it isn't able to interact with external contracts.

This isn't technically true (the Agent app, for instance, doesn't need to be a forwarder and it would still be able to interact with external contracts), but for the majority of use cases this should be true.

The user always has the "custom address" escape hatch, where they could put in their desired app.

@sohkai sohkai self-assigned this Apr 12, 2019

@lkngtn

This comment has been minimized.

Copy link
Member

lkngtn commented Apr 15, 2019

Also not true for the Finance app.

@sohkai

This comment has been minimized.

Copy link
Member Author

sohkai commented Apr 15, 2019

Hmm, good point, it is problematic when there are dependencies involved (e.g. Vault for Finance). With the current metadata provided in apps, we could actually list those dependency apps in the panel based on which app you're selecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.